Repository navigation
Conversation
#3529's source-fill note was hard-wrapped at 100 columns, while the file writes one line per paragraph; that pushed the file to 1001 lines and turned the Lint workflow's check:design-docs step red on main. Rejoin the note onto one line. No words change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Dispatch-Task: main-red-kriszyp_harper_1691ea012_5684deb1
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the documentation in resources/DESIGN.md by joining a multi-line paragraph describing LMDB and RocksDB transaction behaviors into a single line. There are no code changes, and no review comments were provided to evaluate.
Member
Author
|
Closing: — Claude Opus 5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
The Lint Source Code workflow on
mainis red at 1691ea0 (run):npm run check:design-docsfails withresources/DESIGN.md is 1002 lines; the budget is 1000. Keep LMDB source fills from dropping their transaction-log entry or overwriting the source's own write (#3529) added an 11-line note hard-wrapped at 100 columns. The rest of the file puts each paragraph on one line. It passed on its own branch, then landed on amainthat had grown since.🤔 Is this the right requirement?
Yes. The budget check is how notes get pruned, and
mainshould pass it. Fixing the note's wrapping is enough to make it pass without removing any content.💡 Solution
#3529's note on why a source fill's puts carry no condition of their own is now one line, matching the file's style. The file goes from 1002 to 992 lines as the check counts them.
git diff --word-diffis empty, so the wording is unchanged.🤔 Rewrap instead of pruning a note
This leaves 8 spare lines, so adding the next note here requires cutting notes first. That is what the budget asks for. Choosing notes to cut needs each note's owner, and a fix for failing
mainshould not make that call. Rewrapping also avoids conflicts with the open PRs that edit this file.✅ Verification
npm run check:design-docs:design docs: index complete, links resolve, budgets met.npx prettier --check resources/DESIGN.md: clean.git diff -w --word-diff=porcelainshows no word changes.lint:required, the workflow's other step, already passed on the red run, and this PR changes no code.Refs #3529
— Claude Opus 5.5
🤖 Generated with Claude Code
Release target: main — docs-only fix for a check that runs on main
Related PRs: #3529 overlaps (added the paragraph this rewraps), 2 others independent
Complexity: easy
Origin — the dispatch brief this PR was written from
harper main is red: Lint Source Code at 1691ea0
mainon HarperFast/harper went from green to red. Failing workflows: Lint Source Code at 1691ea0.Find the merge that broke it and get main green. Walk that workflow's recent push runs on
mainoldest-to-newest to find the FIRST red head SHA and the PR it came from, then pull the failing test names from that run and from the current head. A failure on every matrix leg (Node version, Bun, uWS, Windows) is a regression; one leg is usually a flake.Then either fix it or, when the culprit is a single merge and the fix is not obvious, open a revert and say so — main being green is worth more than the change being preserved. Record the fingerprint on the
initiatives/ci-healthboard doc either way (prose row beginning with the test path, never a bare ref), and add your PR toinitiatives/testing-and-deploy> "CI & build infrastructure" as a bare-ref line so it renders as a card.Dispatch: task
main-red-kriszyp_harper_1691ea012_5684deb1· queued by automation · ran by claude/opus/high · worker kzyp-xps-1Review-Coverage: authored=claude; ran=gemini,codex,cursor-composer; adjudicated=domain; declined=cursor-grok,muse; rounds=1; full=1 @ b292f2a
Review-Attention: skim ~2m (decisions: budget-by-rewrap-vs-prune) @ b292f2a