Skip to content

Bring resources/DESIGN.md back under its 1000-line budget so main's Lint workflow passes - #3634

Closed
kriszyp wants to merge 1 commit into
mainfrom
fix/resources-design-md-line-budget
Closed

kriszyp wants to merge 1 commit into
mainfrom
fix/resources-design-md-line-budget

Conversation

@kriszyp

@kriszyp kriszyp commented Oct 27, 2026 •

Copy link
Copy Markdown
Member
Kris cranks a folded paper scroll through a press into one flat strip that fits a box while a traffic light turns green in a Utah canyon

⊙ Problem

The Lint Source Code workflow on main is red at 1691ea0 (run): npm run check:design-docs fails with resources/DESIGN.md is 1002 lines; the budget is 1000. Keep LMDB source fills from dropping their transaction-log entry or overwriting the source's own write (#3529) added an 11-line note hard-wrapped at 100 columns. The rest of the file puts each paragraph on one line. It passed on its own branch, then landed on a main that had grown since.

🤔 Is this the right requirement?

Yes. The budget check is how notes get pruned, and main should pass it. Fixing the note's wrapping is enough to make it pass without removing any content.

💡 Solution

#3529's note on why a source fill's puts carry no condition of their own is now one line, matching the file's style. The file goes from 1002 to 992 lines as the check counts them. git diff --word-diff is empty, so the wording is unchanged.

🤔 Rewrap instead of pruning a note

This leaves 8 spare lines, so adding the next note here requires cutting notes first. That is what the budget asks for. Choosing notes to cut needs each note's owner, and a fix for failing main should not make that call. Rewrapping also avoids conflicts with the open PRs that edit this file.

✅ Verification

  • npm run check:design-docs: design docs: index complete, links resolve, budgets met.
  • npx prettier --check resources/DESIGN.md: clean.
  • git diff -w --word-diff=porcelain shows no word changes.
  • lint:required, the workflow's other step, already passed on the red run, and this PR changes no code.
  • PR QA: skipped @ b292f2a — not substantive (docs-only whitespace change)

Refs #3529

— Claude Opus 5.5

🤖 Generated with Claude Code

Release target: main — docs-only fix for a check that runs on main

Related PRs: #3529 overlaps (added the paragraph this rewraps), 2 others independent
Complexity: easy

Origin — the dispatch brief this PR was written from

harper main is red: Lint Source Code at 1691ea0

main on HarperFast/harper went from green to red. Failing workflows: Lint Source Code at 1691ea0.

Find the merge that broke it and get main green. Walk that workflow's recent push runs on main oldest-to-newest to find the FIRST red head SHA and the PR it came from, then pull the failing test names from that run and from the current head. A failure on every matrix leg (Node version, Bun, uWS, Windows) is a regression; one leg is usually a flake.

Then either fix it or, when the culprit is a single merge and the fix is not obvious, open a revert and say so — main being green is worth more than the change being preserved. Record the fingerprint on the initiatives/ci-health board doc either way (prose row beginning with the test path, never a bare ref), and add your PR to initiatives/testing-and-deploy > "CI & build infrastructure" as a bare-ref line so it renders as a card.

Dispatch: task main-red-kriszyp_harper_1691ea012_5684deb1 · queued by automation · ran by claude/opus/high · worker kzyp-xps-1

Review-Coverage: authored=claude; ran=gemini,codex,cursor-composer; adjudicated=domain; declined=cursor-grok,muse; rounds=1; full=1 @ b292f2a

Review-Attention: skim ~2m (decisions: budget-by-rewrap-vs-prune) @ b292f2a

#3529's source-fill note was hard-wrapped at 100 columns, while the file
writes one line per paragraph; that pushed the file to 1001 lines and turned
the Lint workflow's check:design-docs step red on main. Rejoin the note onto
one line. No words change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: main-red-kriszyp_harper_1691ea012_5684deb1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the documentation in resources/DESIGN.md by joining a multi-line paragraph describing LMDB and RocksDB transaction behaviors into a single line. There are no code changes, and no review comments were provided to evaluate.

@kriszyp

kriszyp commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

Closing: main no longer needs this. resources/DESIGN.md is at 996/1000 lines as check-design-docs.mjs counts them on 7ac95e666, and Lint Source Code is green on main (last 3 push runs).

— Claude Opus 5.5

@kriszyp kriszyp closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant