Skip to content

Conversation

@wRAR
Copy link
Member

@wRAR wRAR commented Aug 22, 2025

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5c69dbd) to head (cb4e7e6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          716       716           
  Branches        74        74           
=========================================
  Hits           716       716           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gallaecio Gallaecio marked this pull request as draft August 22, 2025 11:33
@wRAR
Copy link
Member Author

wRAR commented Aug 22, 2025

zyte_api.__main__._main() calls asyncio.get_event_loop(), on Python 3.14+ this won't work, it should create the loop explicitly or, as recommended by the docs, use asyncio.run(). I'll create an issue for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants