Handle empty testcase values in results#543
Merged
Merged
Conversation
matsduf
requested review from
MichaelTimbert,
marc-vanderwal,
matsduf,
mattias-p,
tgreenx and
tolvmannen
matsduf
added
V-Patch
tgreenx
previously approved these changes
May 19, 2026
tgreenx
dismissed
their stale review
@tbleckert Thanks for this, LGTM! Could you just rebase this PR on top of latest develop branch so that CI passes?
tbleckert
force-pushed
the
handle-empty-testcase
branch
from
1470f30 to
e006df9
Compare
Contributor
Author
|
@tgreenx Done! |
matsduf
approved these changes
May 20, 2026
matsduf
left a comment
matsduf
left a comment
Contributor
There was a problem hiding this comment.
It looks fine after update. To trigger timeout I had to lower the value in backend_config.ini. The "test zone" xp.cn was too quick today.
Contributor
|
Looks good to me as well. On my test environment where I lowered the timeout to 60 seconds, testing 
|
marc-vanderwal
approved these changes
May 27, 2026
marc-vanderwal
added
the
S-ReleaseTested
Contributor
|
Successfully tested for the upcoming 2026.1 release. The test run with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes rendering of result entries where the backend returns an empty
testcasevalue.Context
Fixes #541
The reported timeout result is one example of this response shape: the backend can return a valid result entry with
testcase: "". The GUI previously failed to display that entry correctly.Changes
testcasevalues asUnspecifiedwhen grouping results.niceName()tolerate empty input safely.FR26e2e coverage for a result response containing an empty testcase.empty-testcase-responseresult fixture for the e2e test.How to test this PR
Run:
Or manually by testing a domain that results in a timeout.