Skip to content

Add artifact build to the CI#1235

Merged
MichaelTimbert merged 5 commits into
zonemaster:developfrom
MichaelTimbert:artifact
Jun 11, 2026
Merged

Add artifact build to the CI#1235
MichaelTimbert merged 5 commits into
zonemaster:developfrom
MichaelTimbert:artifact

Conversation

@MichaelTimbert

@MichaelTimbert MichaelTimbert commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR adds artifact creation to CI. This artifact can be useful for release testing and PR review.
The artifact is created only if all tests pass.

Context

Follow-up to #1229

How to test this PR

You should be able to download the artifact from the action tab and install it by following the Zonemaster documentation.
https://doc.zonemaster.net/latest/installation/README.html

@matsduf matsduf added V-Patch Versioning: The change gives an update of patch in version. RC-None Release category: Not to be included in Changes file. labels Feb 26, 2026

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Zonemaster-Backend.mo files are missing from the TAR file. I think the MANIFEST unit test should captured that.

@MichaelTimbert MichaelTimbert requested a review from matsduf March 24, 2026 15:04

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives the same content as built on the command line.

@matsduf matsduf added this to the v2026.1 milestone Jun 11, 2026

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same documentation as the other PRs?

I assumed this to have the v2026.1 milestone. Is that correct?

@MichaelTimbert MichaelTimbert merged commit 1a3a5d3 into zonemaster:develop Jun 11, 2026
6 checks passed
@matsduf

matsduf commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I downloaded the zip file (artifact) produced when #1248 was merged, which is at commit 5980bb3, which is where develop branch points at. I took the tar file created locally on FreeBSD from the same commit. I compared the two and only found insignificant differences due to different version of inc::Module::Install being used (1.19 vs 1.21). Only the version identifier differed. This was done as release testing for v2026.1.

@matsduf matsduf added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RC-None Release category: Not to be included in Changes file. S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants