Repository navigation
Name the core API for 1.0 - #3
Merged
Merged
Conversation
Ahead of the stable release, which fixes these names: - MethodParent and MethodParentDeclaration become ContainingTypeKind and ContainingType, with Kind, Name and TypeParameters, matching the 'containing type' the documentation uses. MethodLocation.Parents becomes ContainingTypes. - MethodLocation.IsCSharp14Extension becomes IsInExtensionBlock, and Index becomes OverloadIndex. - ClonedMethod.MethodName becomes FileName, which is what it holds, and DisableNullable becomes NullableDisabled. - ReportedDiagnostic.Trivia becomes MessageArguments, which takes any number of them. - CloningRewriter.ProcessSymbol and ProcessType become Qualify, and MakeType becomes FullyQualifiedName. QualifiedName would have hidden SyntaxFactory.QualifiedName in every rewriter which imports SyntaxFactory statically. Nothing generated changes. Generated with Claude Code
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames in the core API ahead of 1.0, which fixes them. Nothing generated changes.
MethodParent/MethodParentDeclarationContainingTypeKind/ContainingType(Kind,Name,TypeParameters)MethodLocation.Parents/IsCSharp14Extension/IndexContainingTypes/IsInExtensionBlock/OverloadIndexClonedMethod.MethodName/DisableNullableFileName/NullableDisabledReportedDiagnostic.TriviaMessageArguments(params string[])CloningRewriter.ProcessSymbol/ProcessType/MakeTypeQualify/Qualify/FullyQualifiedNameFullyQualifiedNamerather thanQualifiedName, which would hideSyntaxFactory.QualifiedNamein rewriters that importSyntaxFactorystatically.🤖 Generated with Claude Code