Skip to content

Allow to add arguments on nginx-proxy docker run#948

Open
clesquir wants to merge 6 commits into
zodern:devfrom
clesquir:patch-1
Open

Allow to add arguments on nginx-proxy docker run#948
clesquir wants to merge 6 commits into
zodern:devfrom
clesquir:patch-1

Conversation

@clesquir

@clesquir clesquir commented May 23, 2018

Copy link
Copy Markdown

e.g.:

proxy: {
   shared: {
        dockerArgs: [
            '-p 8080:8080'
        ]
    }
}

@zodern

zodern commented Jul 16, 2018

Copy link
Copy Markdown
Owner

Thanks for creating this @clesquir.

Two things:

  1. Since changing the docker arguments effects every app using the reverse proxy, it should be part of reconfigShared.
  2. Move the option to proxy.shared.dockerArgs.

Once #706 is implemented there will be an easier way to add ports, but this PR has many additional uses such as adding networks, volumes, using a custom nginx template, etc.

@clesquir

Copy link
Copy Markdown
Author

Please let me know if there is anything else to be modified!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants