Merged
Conversation
Disable submit buttons while a file upload is in progress so the comment form cannot be submitted before the upload completes (which caused a 500). Re-enable buttons and fade out the bar when the upload queue finishes. Progress bar fills via fileuploadprogressall events. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
thumbnailUrl was always set to the file URL, causing the download template to render a broken <img> pointing at e.g. a .tar.bz2. Now only set thumbnailUrl for image file types so the preview only appears when it would actually render. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
fileuploadstart fires only when the HTTP request begins, leaving a gap during client-side processing where Send was still clickable. Switch to fileuploadadd (fires immediately on file selection) to close that gap. Also handle fileuploadprocessfail so the button re-enables if validation rejects the file before any upload starts. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
… in bar The empty progress bar at 0% width was invisible, making uploads look stuck. Now Send button shows spinner + percentage; bar has min-width and bold text. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…ss bar Replacing the whole Send button HTML on every progress tick was destroying and recreating the spinner span, which restarted its CSS animation each tick. Now only the percentage label inside is updated; the spinner element persists and animates smoothly. Also dropped the Bootstrap classes on the progress bar in favor of inline styles, since the file uploader template suppresses Bootstrap 3 and only the page's Bootstrap 4 alpha is active — its progress styles weren't rendering the bar visibly. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Files that fail validation (too big, wrong type, count exceeded) were only flagged by a small per-row label that was easy to miss. Now a prominent red alert appears above the file list with the failed filename, the translated reason, and for size errors the actual file size and the configured max — so the user knows by how much they're over. Reuses existing translation keys (fajl_slishkom_bolshoj, oshibka, etc.) and the max_file_size context variable already passed to the template. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.