fix(pgvector): normalize index_type to lowercase in _create_index to …#760
Open
shaohuasong-fang wants to merge 2 commits intozilliztech:mainfrom
Open
fix(pgvector): normalize index_type to lowercase in _create_index to …#760shaohuasong-fang wants to merge 2 commits intozilliztech:mainfrom
shaohuasong-fang wants to merge 2 commits intozilliztech:mainfrom
Conversation
…match PostgreSQL access method names PostgreSQL pgvector extension registers index access methods in lowercase (e.g. "hnsw", "ivfflat"), but the frontend passes IndexType.HNSW.value which is uppercase "HNSW", causing "access method HNSW does not exist" error.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shaohuasong-fang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
/assign @jamesgao-jpg |
Author
|
/assign @XuanYang-cn |
Replaced index_param['index_type'] with index_type_lower for consistency.
foxspy
reviewed
Apr 17, 2026
| else sql.Identifier("embedding") | ||
| ), | ||
| index_type=sql.Identifier(index_param["index_type"]), | ||
| [FIX] Use lowercase index_type_lower instead of original index_param["index_type"] |
Collaborator
|
@shaohuasong-fang Mind running this locally first to make sure it works? Thanks! |
Author
|
I have submitted a minor version，url :1a2c0c1 |
Author
|
I forgot copy sign "#" when i copied that line,sorry。 |
Author
|
lastest minor version is 1a2c0c1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…match PostgreSQL access method names
PostgreSQL pgvector extension registers index access methods in lowercase (e.g. "hnsw", "ivfflat"), but the frontend passes IndexType.HNSW.value which is uppercase "HNSW", causing "access method HNSW does not exist" error.