Skip to content

Conversation

@HongNguyen635
Copy link

@HongNguyen635 HongNguyen635 commented Dec 18, 2025

Fixes #101079

This PR moves the init code for en-gpios, m0-gpios and m1-gpios to common init instead of initialize them individually in the driver.

@jilaypandya please let me know if this is the right change you are expecting and appreciate some feedback if not.

@github-actions
Copy link

Hello @HongNguyen635, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

- Include the enable, m0, and m1 microstep to the common init config.
- Refactor drivers that manually init these pins to use the pins
from the common config.

Signed-off-by: Hong Nguyen <[email protected]>
@HongNguyen635
Copy link
Author

first time contributing mistake, I've run check_compliance.py and twister test with native_sim and the commit should be ok now.

@sonarqubecloud
Copy link

Copy link
Member

@jilaypandya jilaypandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HongNguyen635, thanks for the PR! LGTM.
Could you maybe share the test output, just to see if the tests have been passed or skipped ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Stepper platform: ADI Analog Devices, Inc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stepper: Place en-gpios & m0/m1-gpios in common data structure for all step/dir drivers

3 participants