tests: subsys: llext: intel_adsp build and runtime fixes #101227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds board overlays for Intel ADSP platforms to use CONFIG_LLEXT_TYPE_ELF_RELOCATABLE instead of SHAREDLIB as xt-clang cannot link shared libs for Xtensa, exports symbols used by Intel ADSP with Xtensa toolchain, and adds XTENSA MPU / MMU to "no memory protection" config file. Signed-off-by: Lauren Murphy <[email protected]>
Add a Kconfig option for the test to put extensions in .text. This is useful for platforms for which the linker places .data in memory unsuitable for instruction execution, such as Intel ADSP's uncached memory. The theoretical alternative to support Intel ADSP is to add a platform-specific INSTR_FETCHABLE macro and platform-specific heap definition (placing the heap into .rodata) into llext so that the llext loader can copy text into an executable heap, but per a comment at llext_link's llext_link_plt, Xtensa llext's PLT linking is not valid when not performed inline in the ELF buffer. This is because it uses offsets from the text in the ELF buffer and assumes the text section's position relative to the other sections has not changed during loading. If one or more sections, particularly text, are loaded onto the heap, the relocation addresses calculated by the linker will not land in the correct memory region. Signed-off-by: Lauren Murphy <[email protected]>
Adds RAM tags to select Intel ADSP platforms with the primary goal of getting LLEXT subsys tests to run. Signed-off-by: Lauren Murphy <[email protected]>
laurenmurphyx64
added
area: Tests
zephyrbot
added
area: Boards/SoCs
platform: Intel ADSP
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
kv2019i,
lgirdwood,
marcinszkudlinski,
nashif,
npitre,
softwarecki and
tmleman
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: THIS SHOULD NOT BE MERGED BEFORE #101226 IS FIXED!
Fixes build and runtime errors for Intel ADSP platforms with the LLEXT tests.
*The linker puts .data like the LLEXT test extensions in the uncached memory of the Intel ADSP, which can't be executed. But why am I adding a test-specific Kconfig for only one platform? Well, the only alternative I could think of was adding Intel ADSP specific LLEXT heap (placing it in .rodata instead of .data) and INSTR_FETCHABLE definitions** so text would be copied into the heap. But per a comment in llext_link.c's llext_link_plt(), Xtensa llext's PLT linking is not valid when not performed inline in the ELF buffer. This is because it uses offsets from the text in the ELF buffer and assumes the text section's position relative to the other sections has not changed during loading. If one or more sections, such as .text, are loaded onto the heap, the relocation addresses calculated by the linker will not land in the correct memory region. Xtensa seems to not only require WRITABLE storage, but that extensions be properly aligned and placed in executable memory, so that no sections are copied into the heap.
**also only for one platform, and more invasively inserted into the LLEXT subsystem itself instead of just a test
Fixes #100767
...or it would, but there is a bug (?), #101226, where the board overlays this PR adds are ignored by Twister because the testcase.yaml uses extra_conf_files.