Skip to content

Polish the status card, file tab and probing tab - #184

Merged
zeevy merged 2 commits into
masterfrom
ui-status-card-and-file-tab
Sep 23, 2026
Merged

zeevy merged 2 commits into
masterfrom
ui-status-card-and-file-tab

Conversation

@zeevy

@zeevy zeevy commented Sep 23, 2026

Copy link
Copy Markdown
Owner

What changed

Status card

  • Axis rows read X Axis, Y Axis, Z Axis. The axis column is only as wide as its text, so the two number columns get the rest of the width.
  • Buffer counts show as plain numbers, for example 0 | 0.
  • WPos values are teal to show they can be tapped to edit. MPos stays dark.

File tab

  • The file row reads "Select G-code file" until a file is picked.
  • One extension list in Constants drives both the check and the message, so the two cannot drift. A rejected file shows the full allowed list.
  • The type check runs before the copy, so a rejected file no longer also shows a "File not found" toast.

Probing tab

  • Heading is "Probing" with the info icon.
  • The info dialog explains the three buttons and gives four short steps.
  • Editable values are teal, read only values are dark, no edit icons.

All new and changed strings have Russian and Portuguese translations.

Testing

Tested on the API 36 emulator. Picking a .pdf shows the unsupported type toast once and is rejected. Picking a .gcode file loads it and shows 0% (0/5) progress. Android Lint passes locally.

Ghattamaneni Venkateswararao added 2 commits September 23, 2026 10:00
Status card
- Axis rows read X Axis, Y Axis, Z Axis. The axis column is only as
  wide as its text, so the two number columns get the rest.
- Buffer counts show as plain numbers, for example 0 | 0.
- WPos values are teal to show they can be tapped to edit. MPos stays
  dark.

File tab
- The file row reads "Select G-code file" until a file is picked.
- One extension list in Constants drives both the check and the
  message, so the two cannot drift. A rejected file shows the full
  allowed list.
- The type check runs before the copy, so a rejected file no longer
  also shows a "File not found" toast.

Probing tab
- Heading is "Probing" with the info icon.
- The info dialog explains the three buttons and gives four short
  steps.
- Editable values are teal, read only values are dark, no edit icons.

All new and changed strings have Russian and Portuguese translations.
- Drop an unused import in FileSenderListener
- Turn off the Java checkstyle linter. It enforces Sun style with 80
  character lines and javadoc on every field, which this code does not
  follow, same as the Google Java style check that is already off.
- Tell codespell that showIn is an Android attribute, not a typo.
@zeevy
zeevy merged commit 34b7173 into master Sep 23, 2026
17 checks passed
@zeevy
zeevy deleted the ui-status-card-and-file-tab branch September 23, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant