Repository navigation
Polish the status card, file tab and probing tab - #184
Merged
Merged
Conversation
added 2 commits
September 23, 2026 10:00
Status card - Axis rows read X Axis, Y Axis, Z Axis. The axis column is only as wide as its text, so the two number columns get the rest. - Buffer counts show as plain numbers, for example 0 | 0. - WPos values are teal to show they can be tapped to edit. MPos stays dark. File tab - The file row reads "Select G-code file" until a file is picked. - One extension list in Constants drives both the check and the message, so the two cannot drift. A rejected file shows the full allowed list. - The type check runs before the copy, so a rejected file no longer also shows a "File not found" toast. Probing tab - Heading is "Probing" with the info icon. - The info dialog explains the three buttons and gives four short steps. - Editable values are teal, read only values are dark, no edit icons. All new and changed strings have Russian and Portuguese translations.
- Drop an unused import in FileSenderListener - Turn off the Java checkstyle linter. It enforces Sun style with 80 character lines and javadoc on every field, which this code does not follow, same as the Google Java style check that is already off. - Tell codespell that showIn is an Android attribute, not a typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Status card
0 | 0.File tab
Constantsdrives both the check and the message, so the two cannot drift. A rejected file shows the full allowed list.Probing tab
All new and changed strings have Russian and Portuguese translations.
Testing
Tested on the API 36 emulator. Picking a
.pdfshows the unsupported type toast once and is rejected. Picking a.gcodefile loads it and shows0% (0/5)progress. Android Lint passes locally.