v0.2.0-rc2: zecd 0.8.1, legacy Orchard spends work again - #13
Merged
Merged
Conversation
- zecd 0.8.0's PCZT send path proved the Orchard-pool bundle with the NU6.2 circuit's key, which the prover refuses after NU6.3 (Prover(ProofFailed(InvalidInstances))). Databases carried over from zkv v0.1.0 hold such notes, so v0.2.0-rc1 could not send or write from them. - 0.8.1 proves under the circuit the consensus branch names. No zkv source change; the lockfile moves zecd's entry alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release candidate 2 for v0.2.0. Not tagged yet.
v0.2.0-rc1 cannot send or write from a database whose funds sit in the legacy Orchard pool: every attempt fails with
Orchard proof generation failed: Prover(ProofFailed(InvalidInstances))and broadcasts nothing. That covers funds received before NU6.3 activated and change that older software, zkv v0.1.0 included, kept in the Orchard pool afterwards. The cause was in the wallet engine: zecd 0.8.0 proved such spends with the NU6.2 circuit's key, which the prover refuses after NU6.3.0.2.0-rc2. The website stays on v0.1.0 until the final release.Checked locally: fmt, clippy, 466 tests, a
--features desktopbuild and clippy, MSRV 1.91,cargo deny, rustdoc, the Zakura graph check andcargo publish --dry-run.