fix: auto-resolve IDs and strip ObjectID prefixes#171
Merged
Conversation
- ObjectID() now auto-strips prefixes (e.g. "service-xxx" → "xxx") so users can pass prefixed IDs without errors - Log command resolves projectID and environmentID from serviceID instead of relying on context (which may point to a different project) - Refactored log API to use proper subscription parameters (projectID, serviceID, environmentID) matching backend GraphQL schema - Auto-resolve environmentID across all commands that need it (deploy, service operations) since environments are deprecated - Use graphql-ws protocol for WebSocket subscriptions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectID()auto-strips prefixes likeservice-,project-,environment-,deployment-so users can pass prefixed IDs directlydeployment log --service-idnow resolvesprojectIDandenvironmentIDfrom the service itself, instead of relying on context (which may point to a different project)environmentIDacross all commands (deployment get/list, service delete/expose/metric/redeploy/restart/suspend, update tag) since environments are deprecatedprojectID,serviceID,environmentID)graphql-wsprotocol for WebSocket subscriptionsTest plan
deployment log --service-id service-xxxreturns logs from the correct projectgo build ./...passesgo test ./...passes🤖 Generated with Claude Code