-
-
Notifications
You must be signed in to change notification settings - Fork 371
feat/global concurrency limit #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…v-b/zarr-python into feat/global-concurrency-limit
|
Nice, the other one that bugs me when profiling is zarr-python/src/zarr/codecs/zstd.py Line 79 in b3e9aed
|
…at/global-concurrency-limit
|
@d-v-b do you have thoughts on how downstream libraries would interact with Zarr's concurrency limit? Would those set there own concurrency approaches (e.g., global or per function) or could there be a way to share the limit with Zarr? |
|
@maxrjones this PR is moving away from a global concurrency limit because it's actually very hard to implement a top-down concurrency control in our codebase. the new direction I'm taking with this PR is for each store to set its own concurrency limit. for stateless stores like local and remote (basically anything except zip), concurrency-sensitive applications should be able to cheaply create store instances with concurrency limits tuned to the needs of the application. |
Makes the concurrency limit global, rather than per-function.
I'm not emotionally attached to this PR -- it's largely the work of claude code. Lets use this as a starting point for improving on #3526