fix(ci): announce Skill releases without free-form text and verify the result - #13
Merged
Merged
Conversation
…e result The Skill release job forwarded the whole GitHub release object to the package receiver, so the announcement depended on how the release notes were worded. A body containing a shell pipeline was rejected by the receiver's edge protection with HTTP 403, and because the package cache has no expiry of its own, the previous Skill stayed published with nothing failing to show it. The step also retried that 403 four times and then reported an opaque failure. Announce only the fields the receiver reads (action, release.tag_name, and each asset's name and browser_download_url), report a 4xx immediately instead of retrying it, and add a gate that polls the public endpoint until it actually serves the released tag before the job is allowed to succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Skill release job forwarded the entire GitHub release object to the package
receiver, so whether a release could be announced depended on how its notes were
worded. For
skill-v1.1.7the notes contained a shell pipeline in a code span,the receiver's edge protection answered
403, and both announcement paths failed:Two things then made a transient rejection into a lasting one. The package cache
has no expiry, so the endpoint kept serving the previous Skill indefinitely with
no signal that anything was wrong. And the step trusted its own
2xxinstead ofchecking the outcome, so nothing failed to reveal it.
Changes
action,release.tag_name, and each asset'snameandbrowser_download_url. Release notes and other free-form text no longer enter the request body. The receiver needs no change.4xximmediately rather than retrying it.--retry-all-errorspreviously retried the403four times and then reported an opaque failure.GET /v1/skill/package?format=...for both formats until the302redirect target ends in the released tag, failing the job on timeout. The redirect already carries the served version, so this costs one request per poll and downloads nothing.Verification
Measured against the live endpoint, same headers, same deliberately invalid signature:
403blocked at the edge401reaches the application401reaches the application401is the receiver rejecting the signature, which is the expected answer foran unsigned probe and proves the request is no longer stopped before it arrives.
skill-v1.1.7release JSON: 5730 bytes in, 353 bytes out, containing only the three expected fields.Location, a stale tag, a response with noLocation, and a similar-prefix tag (skill-v11.1.7must not satisfyskill-v1.1.7).bash -n; the workflow parses as YAML with 7 steps.npm run lintclean,npm test140/140,npm pack --dry-rununchanged at 71 files.Not covered here
The receiver's cache still has no expiry, so it cannot converge on its own if
every announcement fails; this gate makes that loud rather than silent. The
repository also has a native GitHub webhook for
releaseevents whose payloadis generated by GitHub and therefore still carries release notes.