Add ability to change individual icons#67
Open
shotaroikeda wants to merge 35 commits intoyoavlt:swift-2.0from
Open
Add ability to change individual icons#67shotaroikeda wants to merge 35 commits intoyoavlt:swift-2.0from
shotaroikeda wants to merge 35 commits intoyoavlt:swift-2.0from
Conversation
change floatingActionButton => liquidFloatingActionButton
TODO: default color should be the default color of the button
Author
|
I've also exposed LiquidtableCircle.color so that the user can set them |
Author
|
I also forgot to update travis to use cocoapods 1.0.1 instead, my mistake |
Owner
|
Thank you for great contribution! |
Author
|
Unfortunately I don't know how travis works (I've fixed everything up to actually running the tests themselves), but as far as I know it seems like it's failing at the testing stage. Apparently switching from |
Author
|
I'm since fixed swift-3 support, though the build still seems to be failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to change icon colors so that they display smoothly, updated the podspec to completely support Cocoapods 1.0.1, and removed some build warnings that occured with XCode 7.
The only thing you'll want to check before the merge is the podspec's description and the installation instructions for the README, since it points to me rather than to you.
-Cheers!