[yingbo]

Summary

Adds an Apply button to the run configuration editor, makes double-click open a configuration from the sidebar, and puts a confirmation between those two conveniences and losing unsaved edits. Also corrects documentation that had drifted from the code.

Version is bumped to 1.4.0. No tag is created here, so nothing publishes until v1.4.0 is tagged.

Editor: Apply and Save & Close

The editor could only be saved by closing it, so tweaking a configuration and re-running it meant reopening the editor each time.

• Apply writes the form to launch.json and leaves the panel open, with a brief "Changes applied" note.
• Save is renamed Save & Close so the two are distinguishable. Its behaviour is unchanged.
• Both go through a single ConfigEditorProvider.persist(), which clears the isNew flag after the first write. Repeated Apply clicks on a new configuration therefore add it once and update it in place afterwards, instead of appending duplicates.

Tree: double-click to edit

ConfigTreeItem now carries a command that fires on every click. VS Code exposes no double-click event for tree views, so the handler measures the gap between two clicks on the same item within a 500 ms window.

One edge case is handled: when workbench.list.openMode is set to doubleClick, VS Code already withholds the command until the second click, so the handler opens the editor on the first invocation rather than demanding two double-clicks.

Unsaved-change guard

Cancel disposed the panel immediately, and opening another configuration re-rendered the same panel, so either one silently discarded whatever was typed. That was survivable when opening the editor took a context-menu click; double-click makes landing on the wrong row easy.

The extension cannot read the form, so the webview compares it against the last saved snapshot and posts dirtyState when that changes. Input and change events cover every field including rows added after load, button-driven mutations are picked up on the next tick, and the browse dialogs re-check when they write a path back. Apply re-baselines.

The provider consults the flag before Cancel closes the panel and before open() renders a different configuration, showing a modal with a Discard Changes action. Re-opening the configuration already on screen now reveals the panel untouched, so a stray double-click on the open configuration cannot cost anything.

Known limitation: VS Code cannot veto a webview panel's disposal, so closing the editor tab still discards without a prompt. This is recorded in worklog.md.

Documentation corrections

Several documents had drifted from the code:

• FEATURE_SPEC.md and worklog.md described configurations as living in a private .vscode/python-run-configs.json. That has not been true since storage moved into .vscode/launch.json as debugpy entries tagged charmrunManaged.
• docs/pycharm-comparison.md still listed before-launch tasks as a gap against PyCharm, but that shipped in 1.1.0.
• worklog.md claimed 12 registered commands where 15 are registered; openConfigurationFlow and adoptLaunchConfiguration had never been listed.
• docs/PUBLISHING.md stopped at ovsx create-namespace, which only grants contributor rights. Without a namespace owner every published version carries the "not a verified publisher" warning on open-vsx.org, so the ownership-claim step is now documented.

Authorship rules

AGENTS.md banned Co-Authored-By lines, but that was narrow enough to read as the only prohibited trailer, and other attribution slipped through. The rule is now stated once and completely: no attribution trailer, footer, badge or marker of any kind, anywhere, and the commit author and committer are always the repository owner. CLAUDE.md carries the same rule, and CONTRIBUTING.md mirrors the summary.

Screenshot

main already replaced the hand-drawn mockup with a render of the real webview, which was the right call. That render predates this branch, so it still shows a lone Save button.

This updates it to the current editor and adds scripts/screenshot.mjs so it can be regenerated on demand rather than by hand. The script bundles the editor's own HTML generator, feeds it a sample configuration, supplies the theme variables and webview API that VS Code injects at runtime, and screenshots the result in headless Chromium before framing it with the configurations sidebar. Regenerating is one command, documented in CONTRIBUTING.md.

playwright-core stays out of package.json since only this script needs it, and scripts/ is excluded from the packaged VSIX.

Testing

Typecheck, lint, and the esbuild bundle pass.

The dirty tracking was verified by driving the generated form in headless Chromium, since an extension host is not available in this environment. Eight checks, all passing: clean on load, dirty after an edit, clean again when the edit is reverted, an empty new env row stays clean while filling its key goes dirty, and Cancel carries the right state both before and after Apply.

Not yet verified by hand: how the modal reads and how the double-click timing feels in a real Extension Development Host. Worth a pass with F5 before merging.

Note on history

This branch was built before main was force-updated to a rewritten history, so it originally shared no ancestor with it. It has been rebased onto the current main; the only conflict was the screenshot, resolved in favour of the version that shows the new buttons. main's README install section is preserved intact.