Repository navigation
Add CI, set PG 14+ floor, and sync AGENTS.md - #12
Merged
Merged
Conversation
Add a GitHub Actions workflow that runs the regression suite on PostgreSQL 14-18 against all three install paths: standalone build, pg_tle (built from a pinned commit), and filesystem CREATE EXTENSION in both the default and an explicit schema. Add make install/uninstall and test-local, test-tle, test-extension targets that recreate a scratch database per run. The test suite previously exited 0 even with failures; it now raises at the end when any assertion fails, and compares with IS NOT DISTINCT FROM so NULL results count as failures instead of being dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JAaWhjV4FjNThbcAAWksS
Declare PostgreSQL 14 as the minimum supported version (12 and 13 are past upstream EOL and not covered by CI) in AGENTS.md and README.md, and document how to maintain the CI version matrix and pg_tle pin. Bring AGENTS.md in line with the code: row_to_toon takes anyelement, list the toon_agg state/final helper functions, and point the new-function checklist at the make test targets. Fix the workflow push trigger to use the default branch, master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JAaWhjV4FjNThbcAAWksS
sudo resets the environment, so createuser ignored PGPORT=5499 and tried the default 5432 socket, failing every matrix job at cluster setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JAaWhjV4FjNThbcAAWksS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI and test targets
.github/workflows/test.ymlruns the regression suite on PostgreSQL 14–18. It covers all three install paths: the standalone build, pg_tle (built from a pinned commit), and a filesystemCREATE EXTENSIONinto both the default schema and an explicit one.install/uninstall,test(alias fortest-local),test-tleandtest-extension. Each target recreates a scratch database for its run.test_pgtoon.sqlused to exit 0 even when assertions failed. It now raises an error at the end if anything failed.assert_toonnow compares withIS NOT DISTINCT FROM, so a NULL result counts as a failure instead of being dropped from the count.Docs
row_to_toontakesanyelement, the list now includes thetoon_aggstate and final helper functions, and the new-function checklist uses themake test*targets.Notes
test-tlehas to run beforemake install, because pg_tle won't register an extension that's already installed on the filesystem.🤖 Generated with Claude Code
https://claude.ai/code/session_014JAaWhjV4FjNThbcAAWksS
Generated by Claude Code