perf: Drop irrelevant caller bounds from query type op keys [-0.16% primary; -21.5% async-trait-heavy] - #79
Draft
xmakro wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query type ops are keyed on a canonicalized parameter environment. A where clause that mentions the implementing type, such as the
Self: 'athat async trait desugaring produces, therefore gives every impl a distinct key, and the work behind that key is repeated per impl instead of shared once. The effect is concentrated in MIR borrow checking, and it is not specific to regions: a bound with no regions at all shows the same behaviour, while a bound that is the same in every impl does not.When the goal itself mentions no parameters, a caller bound that does mention one cannot apply to it, and outlives bounds can never apply either, since candidate assembly keeps only trait clauses. In that case the empty environment is substituted into the query key. This happens at the single point where every query type op canonicalizes, and the original environment is kept for region instantiation, so only the key changes.
tests/ui passes.