perf: Avoid freshening the same predicate twice per selection - #78
Draft
xmakro wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection freshens the obligation predicate once when pushing it onto the stack, then freshens the same predicate again in candidate_from_obligation to build the cache key. Both happen before the cache is probed, so the second fold is paid even on hits.
When the predicate contains no type or const inference variables the two results are identical: the freshener's only state-dependent paths are its inference variable arms, and its region handling is stateless erasure. The gate is therefore on non-region inference variables rather than on inference variables generally, since region variables cannot reach the stateful paths and are pervasive in selection obligations.
The freshened predicate is a cache key, so a debug assertion recomputes the fold and compares. A future change to the freshener that breaks the equivalence fails loudly under debug assertions instead of silently corrupting the selection cache.