perf: Avoid intermediate allocations in nominal_obligations [-0.28%] - #75
Draft
xmakro wants to merge 1 commit into
Draft
perf: Avoid intermediate allocations in nominal_obligations [-0.28%]#75xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
xmakro
force-pushed
the
perf/wf-nominal-obligations
branch
from
July 31, 2026 09:18
38427be to
a255c2a
Compare
xmakro
force-pushed
the
perf/wf-nominal-obligations
branch
from
July 31, 2026 09:37
a255c2a to
ba60431
Compare
xmakro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WfPredicates::nominal_obligationsbuilt a per-predicateVecof origins and a fully instantiatedInstantiatedPredicatesas intermediates before collecting the result. Walk the parent chain into an inlineSmallVecand instantiate each level directly into a presized result withinstantiate_own, so a call allocates just the returned obligations.The
trace!in this function now logs the built obligations rather than the instantiated predicates, because the intermediate it used to print no longer exists.