perf: Avoid a heap allocation per basic block in MoveData's location maps - #73
Closed
xmakro wants to merge 1 commit into
Closed
perf: Avoid a heap allocation per basic block in MoveData's location maps#73xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
xmakro
force-pushed
the
perf/location-map-single-alloc
branch
3 times, most recently
from
July 31, 2026 04:52
606f7ab to
942e5f9
Compare
xmakro
changed the title
xmakro
force-pushed
the
perf/location-map-single-alloc
branch
from
July 31, 2026 04:59
942e5f9 to
10f3e23
Compare
xmakro
force-pushed
the
perf/location-map-single-alloc
branch
from
July 31, 2026 05:02
10f3e23 to
6f198ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoveDataholds twoLocationMaps, and each was anIndexVec<BasicBlock, Vec<T>>that heap-allocated oneVecper basic block. Building the move data for a body allocated a small vector for every block, twice over. Store the entries in one flat buffer indexed by a per-block start offset, so each map is two allocations regardless of block count.