Skip to content

pnpm validateDocs always fails - script parses a symbol that no longer exists #914

Description

@amcclain

client-app/scripts/validate-doc-registry.mjs always exits 1.

The script builds its expected-docs set by regexing HOIST_REACT_SOURCE_PATHS out of client-app/src/desktop/tabs/docs/docRegistry.ts (see parseRegistryPaths(), around line 46). That symbol no longer exists anywhere under client-app/src - not on this branch, and not on develop. The regex matches nothing, so the script reports "0 entries" against the 64 doc files it finds in the installed @xh/hoist, lists every one as missing, and exits 1.

$ pnpm validateDocs
...
Doc registry: 0 entries, @xh/hoist has 64 doc files (8 ignored), version 88.0.0-SNAPSHOT...
🔧 Update HOIST_REACT_SOURCE_PATHS in docRegistry.ts or the server-side DocRegistry.groovy.

The doc registry moved server-side (DocsService / DocRegistry.groovy), which the script's own header comment acknowledges - but its check was never repointed at the new source of truth.

Nothing runs it: it is not part of pnpm lint and no workflow calls it, so the failure has been silent.

Fix should either repoint the check at the server-side registry (and wire it into CI so it cannot rot again) or delete the script and its validateDocs package script.

Found while auditing docs/paperwork on the rsbuild-spike branch - unrelated to that work, pre-existing on develop.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions