Add tested support for MSI Alpha 17 C7VF / C7VG - #161
Conversation
|
@Liuwins Thank you for this - a careful, well-built PR, and the first outside contribution to the model database. It arrived in parallel with our own work on your reports: everything it proposes is already on main as of today (commits 14a4ab5 and e860420) - the tested tier, the tachometers at 0xC9/0xCB, the verified curve, and notably the same call you made independently on 0xEB: your capture in #151 showed MSI Center never touches it on this board, so the recipe skips that write. You are in the entry's credit, and the update is live in the signed model database. Closing this PR as superseded rather than merging: the branch now conflicts with main in all five files, and data/models.json plus its signature have to be regenerated with the repository's signing key on the maintainer's side anyway, exactly as you noted. Thanks again - report sets like your #151-#153 are what moves this database forward. |
Summary
Add tested support for the MSI Alpha 17 C7VF / C7VG on EC firmware
17KKIMS1based on the owner's reports in issues #151, #152, and #153.Type of change
Related issue or discussion
Changes
17KKIMS1from Experimental to Tested.0xC9/0xCB.0x72/ GPU0x8Aas verified.0xD2/0xD4profile recipes.0xEBstayed0x00in all four MSI Center scenarios, so the Alpha profile deliberately does not write an unverified Super Battery register.data/models.jsonanddocs/SUPPORTED_MODELS.md, update the model counts, and add a changelog entry.User-visible changelog
17KKIMS1.0xEBon this model because MSI Center left it at0x00in every captured scenario.Contribution authorship and code origin
The register values and hardware observations come from Liuwins' read-only reports in issues #151, #152, and #153. No code was adapted or ported from another project.
AI assistance
AI was used for code generation, code review, debugging, documentation, and research/explanation. The submitter reviewed the resulting diff and remains responsible for the contribution.
Testing
Test environment
Checks performed
dotnet build GhostDeck.csproj -c Release --no-restore— 0 warnings, 0 errorsGhostDeck.dll --verify-models data/models.json— 149 models, round-trip byte-identical, matches compiled tablespython tools/lang-check.py— 701 keys translated in all 15 languages, no duplicate keys0xC9/0xCBRPM, verified0x72/0x8Acurve, and no0xEB=0x0FwriteMaintainer follow-up
data/models.jsonis intentionally updated together with the compiled tables, but its detached signature cannot be regenerated here because the repository signing private key is not available to the contributor. Before merging, please runpwsh tools/sign-models.ps1with the repository's original signing key and commit the resultingdata/models.json.sig. The public key and trust root are unchanged.