Skip to content

[NU-444] Update product notification labels and email#6310

Merged
joaquinco merged 3 commits into
masterfrom
nu-444/feedback-changes
Jul 2, 2026
Merged

[NU-444] Update product notification labels and email#6310
joaquinco merged 3 commits into
masterfrom
nu-444/feedback-changes

Conversation

@joaquinco

Copy link
Copy Markdown
Collaborator

Notes

  • Update some labels and email
  • Allow single reservation controller new action to receive a start_at parameter where to find the next available reservation to be used in the next available reservation email

Part of NU-444 | An automatic email that would notify user of canceled reservations

@joaquinco joaquinco force-pushed the nu-444/feedback-changes branch from 3c52eff to 0f0287d Compare June 29, 2026 19:50
@joaquinco joaquinco marked this pull request as ready for review June 30, 2026 13:06

@LeticiaErrandonea LeticiaErrandonea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# reservation times to display
class NextAvailableReservationFinder
def initialize(product)
attr_reader :product, :start_at

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Is the product accessor being used?

@joaquinco joaquinco merged commit 7cd8fb3 into master Jul 2, 2026
8 checks passed
@joaquinco joaquinco deleted the nu-444/feedback-changes branch July 2, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants