Debug trip mode choice - #3
Open
josiekre wants to merge 2 commits into
Open
Conversation
Member
Author
|
Via @mnbina in Teams:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the availability matrix. With the test data, the following counts resulted:
We can see that now RIDEHAIL is available at the trip level for valid combinations according to the documented table here: CTPSSTAFF#12
At the tour level, RIDESHARE still holds ~23% of tours.

At the trip level, RIDESHARE now is ~9% of trips and before it was 1%.

However, if you also look at trips with WALK that are in a tour with RIDESHARE, the numbers align.

Please check my work here. Does this satisfy debugging trip mode (ignoring the fact that RIDESHARE is still at 23% which will be addressed elsewhere)?
I am going to come back to this pull request if there is time and do some more clean up so do not yet merge it. Items to be cleaned up:
DRIVEALONEFREEandDRIVEALONEPAYfrom trip and tour mode filestour_mode_is_non_motorizedreferences remaining in code