Skip to content

Fix serialize bug on detached / continuation mismatch #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wsmoses wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix serialize bug on detached / continuation mismatch #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/Transforms/Utils/SimplifyCFG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6011,8 +6011,13 @@ static bool serializeTrivialDetachedBlock(BasicBlock *BB) {
// This detached block is empty
// Scan predecessors to verify that all of them detach BB.
for (BasicBlock *PredBB : predecessors(BB)) {
if (!isa<DetachInst>(PredBB->getTerminator()))
return false;
if (auto DI = dyn_cast<DetachInst>(PredBB->getTerminator())) {
// check that we are the detached (and not continuation)
if(DI->getDetached() != BB) return false;

@neboat neboat Jul 23, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistent code style, I'd prefer a space between the if and first (.

} else {
// don't serialize if nondetached predecessor
return false;
}
}
// All predecessors detach BB, so we can serialize
for (BasicBlock *PredBB : predecessors(BB)) {
Expand Down