Add wasm tooling crate to v1#452
Draft
dcbuild3r wants to merge 2 commits into
Draft
Conversation
The single monolithic "Build and test" job ran fmt, clippy, build, test, doc-test, and doc sequentially on one runner. Each `--all-targets --all-features` cargo invocation accumulated artifacts on the same disk. Adding the `provekit-wasm` crate and its dependency tree (wasm-bindgen, web-sys, etc.) pushed that single disk over the limit, causing the build step to fail with "No space left on device". Split into separate build/clippy/fmt/doc jobs, each on its own runner with a fresh disk, mirroring the structure already used on `main`. Clippy was already passing before the failure, confirming the workspace (including the wasm crate) compiles for the host target; this is purely a disk-capacity fix, not a source change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tooling/provekit-wasmcrate frommainto thev1workspace.wasm32-unknown-unknownrustflags required bywasm-bindgen-rayon.v1artifacts:v1uses a 20-byte binary header and hasProveras a struct rather than the newermainenum shape.Why
This brings the wasm tooling crate onto the
v1branch while keeping the implementation scoped to the wasm package and the build configuration it needs.Validation
cargo fmt --all --checkcargo check -p provekit-wasm --target wasm32-unknown-unknown -Z build-std=panic_abort,stdcargo test -p provekit-wasm --lib(15 passed)The focused checks pass. The build still reports existing warnings from the v1 verifier
FinalClaimhandling and the expected unstable wasm atomics target-feature warning.