Skip to content

feat(router): make usage accounting authoritative - #766

Open
steventohme wants to merge 6 commits into
mainfrom
translation-hardening-pr4
Open

feat(router): make usage accounting authoritative#766
steventohme wants to merge 6 commits into
mainfrom
translation-hardening-pr4

Conversation

@steventohme

Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @steventohme's task —— View job


Posted 3 comment-length suggestions (advisory, won't block merge).

@steventohme
steventohme marked this pull request as ready for review July 17, 2026 01:36

@workweave-bot workweave-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory only — comment-length nits. Won't block merge.

Comment thread internal/providers/provider.go Outdated
Comment thread internal/proxy/telemetry.go Outdated
Comment thread internal/proxy/usage_accounting.go Outdated
Comment thread internal/observability/otel/usage.go
@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown

T-Rex T-Rex Logs

What T-Rex did

  • Attempted runtime verification of the Gemini scenario, but progress was blocked by a missing durable marker; static inspection shows Gemini.emitBilling on successful requests, an early return for non-authoritative usage, and InsertTelemetryParams with usage details in the service layer.
  • Validated the usage authority tests by reviewing the runtime logs, which show translate, proxy, and OpenTelemetry paths passing with exit code 0.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "feat(router): make usage accounting auth..." | Re-trigger Greptile

Comment thread internal/proxy/gemini.go
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @steventohme's task —— View job


  • Run git diff to find added comment blocks
  • Evaluate comment blocks for verbosity
  • Post suggestions if any found

Posted 3 comment-length suggestions (advisory, won't block merge).

View job

Comment thread internal/translate/stream.go Outdated

@workweave-bot workweave-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory only — comment-length nits. Won't block merge.

@workweave-bot workweave-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory only

Comment thread internal/providers/provider.go Outdated

@workweave-bot workweave-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory only — comment-length nits. Won’t block merge.

Comment thread internal/providers/provider.go Outdated
Comment thread internal/proxy/telemetry.go Outdated
Comment thread internal/translate/usage_reducer.go Outdated
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @steventohme's task —— View job


  • Run git diff to find added comment blocks
  • Evaluate comment blocks for verbosity
  • Post suggestions if any found

View job

Comment thread internal/translate/gemini_stream.go Outdated
Comment thread internal/translate/stream.go Outdated
Comment thread .github/workflows/provider-contract-refresh.yml
Comment thread internal/observability/otel/usage.go
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @steventohme's task —— View job


  • Run git diff to find added comment blocks
  • Evaluate comment blocks for verbosity
  • Post suggestions if any found

View job

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d7974c. Configure here.

Comment thread db/queries/model_router_request_telemetry.sql
Comment thread internal/proxy/gemini.go
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown

Claude finished @steventohme's task —— View job


  • Run git diff to find added comment blocks
  • Evaluate comment blocks for verbosity
  • Post suggestions if any found

No 3+ consecutive added comment blocks found in non-generated Go files on the current HEAD. Previous runs addressed the earlier commits.

View job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants