Remove wp-scripts e2e toolchain#2211
Merged
Merged
Conversation
The e2e test toolchain (wp-scripts, Puppeteer) was removed in a prior commit. Remove the now-unused CI workflow file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add npm overrides to force axios >= 1.15.1, resolving the vulnerability in the transitive dependency chain: @wordpress/scripts → jest-dev-server → wait-on → axios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gigitux
approved these changes
May 11, 2026
gigitux
left a comment
Contributor
There was a problem hiding this comment.
I left few comments, but I'm pre-approving the PR. Thanks for working on this!
Address review feedback: the removed e2e workflow was the only CI job running `npm run build`. Add a lightweight build validation job to the existing linting workflow to catch JS/CSS compilation regressions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Luigi Teschio <gigitux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started as a dependency update to address the Axios security issue. However, I noticed that we only have that package because it's a dependency of
wp-script, and we only usewp-scriptfor E2E testing. Our E2E test suite has only one simple test that can be covered by our PHP test. So, I decided to remove the ET test and all of the wp-script dependencies.Testing:
npm run lint:js✅npm run test:php✅Changelog: