Skip to content

Remove wp-scripts e2e toolchain#2211

Merged
dinhtungdu merged 5 commits into
trunkfrom
fix/axios-ghsa-m7pr-hjqh-92cm
May 11, 2026
Merged

Remove wp-scripts e2e toolchain#2211
dinhtungdu merged 5 commits into
trunkfrom
fix/axios-ghsa-m7pr-hjqh-92cm

Conversation

@dinhtungdu

@dinhtungdu dinhtungdu commented May 7, 2026

Copy link
Copy Markdown
Member

Started as a dependency update to address the Axios security issue. However, I noticed that we only have that package because it's a dependency of wp-script, and we only use wp-script for E2E testing. Our E2E test suite has only one simple test that can be covered by our PHP test. So, I decided to remove the ET test and all of the wp-script dependencies.

Testing:

  • npm run lint:js
  • npm run test:php
  • Verify the built is identical:
# Verify built assets are identical to trunk
TRUNK_DIR="$(mktemp -d)"
trap 'rm -rf "$TRUNK_DIR"' EXIT
git clone --branch trunk --depth 1 --single-branch . "$TRUNK_DIR" 2>/dev/null
(cd "$TRUNK_DIR" && npm ci --silent 2>/dev/null && npm run build:dev --silent 2>/dev/null)
npm ci --silent 2>/dev/null && npm run build:dev --silent 2>/dev/null
diff -rq assets "$TRUNK_DIR/assets" && \
diff -q style.css "$TRUNK_DIR/style.css" && \
diff -q style-rtl.css "$TRUNK_DIR/style-rtl.css" && \
echo "✅ No differences" || echo "❌ Differences found"

Changelog:

Dev – Remove wp-scripts e2e tooling and cover the footer credit smoke test in PHP.

dinhtungdu and others added 3 commits May 7, 2026 22:06
The e2e test toolchain (wp-scripts, Puppeteer) was removed in a prior
commit. Remove the now-unused CI workflow file.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add npm overrides to force axios >= 1.15.1, resolving the vulnerability
in the transitive dependency chain: @wordpress/scripts → jest-dev-server
→ wait-on → axios.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dinhtungdu dinhtungdu requested review from a team and gigitux and removed request for a team May 11, 2026 03:11

@gigitux gigitux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments, but I'm pre-approving the PR. Thanks for working on this!

Comment thread package.json Outdated
Comment thread .github/workflows/e2e-tests.yml Outdated
dinhtungdu and others added 2 commits May 11, 2026 16:35
Address review feedback: the removed e2e workflow was the only CI job
running `npm run build`. Add a lightweight build validation job to the
existing linting workflow to catch JS/CSS compilation regressions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Luigi Teschio <gigitux@gmail.com>
@dinhtungdu dinhtungdu merged commit ec05314 into trunk May 11, 2026
8 checks passed
@dinhtungdu dinhtungdu deleted the fix/axios-ghsa-m7pr-hjqh-92cm branch May 11, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants