Repository navigation
Added more argument check in wc_PBKDF1_ex() - #12059
Merged
Merged
Conversation
|
retest this please |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the PBKDF1 salt-validation update.
No open issues 🎉
What changed in this PR
This PR addresses F-11150 by aligning wc_PBKDF1_ex() salt argument validation with wc_PBKDF2_ex().
Changes:
- Return
BAD_FUNC_ARGwhen salt isNULLandsaltLenis positive. - Add tests for rejecting a NULL salt with a positive length and accepting it with zero length.
| File | Description |
|---|---|
wolfcrypt/src/pwdbased.c |
Adds the NULL salt and positive-length argument check. |
tests/api/test_pwdbased.c |
Tests rejected and permitted NULL salt inputs. |
Review effort: Balanced
|
dgarske
approved these changes
Nov 9, 2026
JacobBarthelmeh
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix F-11150. wc_PBKDF1_ex() now rejects a NULL salt with a non-zero saltLen, matching wc_PBKDF2_ex().
Testing
Added NULL salt cases to test_wc_PBKDF1DecisionCoverage.
Checklist