Skip to content

Pq fs 2026 part4 fenrir v7 indicator - #12057

Open
kaleb-himes wants to merge 4 commits into
wolfSSL:masterfrom
kaleb-himes:PQ-FS-2026-Part4-Fenrir-v7-indicator
Open

kaleb-himes wants to merge 4 commits into
wolfSSL:masterfrom
kaleb-himes:PQ-FS-2026-Part4-Fenrir-v7-indicator

Conversation

@kaleb-himes

Copy link
Copy Markdown
Contributor

Description

Please describe the scope of the fix or feature addition.

Fixes zd#

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kaleb-himes kaleb-himes self-assigned this Nov 8, 2026
Copilot AI balanced review requested due to automatic review settings November 8, 2026 00:10

This comment was marked as outdated.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report · Explore what changed →

gcc-arm-cortex-m4-crypto-only

  • FLASH: .text +64 B (+0.0%, 181,779 B / 262,144 B, total: 69% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .text +64 B (+0.0%, 801,572 B / 1,048,576 B, total: 76% used)

zephyr-frdm_rw612

  • FLASH: log_const_area -8 B, rodata -8 B, text +1,648 B (+0.6%, 284,096 B / 67,108,864 B, total: 0% used)

No memory changes detected for:


Catch memory regressions in CI with MemBrowse. Free for open source.

wolfSSL-Fenrir-bot

This comment was marked as resolved.

@kaleb-himes
kaleb-himes force-pushed the PQ-FS-2026-Part4-Fenrir-v7-indicator branch 2 times, most recently from 2812c33 to 1836dd2 Compare November 9, 2026 16:57
@kaleb-himes
kaleb-himes requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot November 9, 2026 16:58

This comment was marked as resolved.

wolfSSL-Fenrir-bot

This comment was marked as resolved.

@kaleb-himes
kaleb-himes force-pushed the PQ-FS-2026-Part4-Fenrir-v7-indicator branch from 1836dd2 to 49faba6 Compare November 9, 2026 18:23
@kaleb-himes
kaleb-himes requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot November 9, 2026 18:24

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #12057

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot dismissed stale reviews from themself November 9, 2026 18:27

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The FIPS v7 wrappers and indicator definitions are absent from this checkout, preventing independent validation of the security-sensitive return-value normalization, completed-output semantics, and ECC refusal behavior.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants