Repository navigation
Conversation
Function name in example code had extra underscore. 'secret' needs to be unsigned. WOLFSSL_TLS13_SHA512 needs to be defined for SHA-512 to be used.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the documentation-only updates to the English and Japanese API examples and digest-selection guidance.
No open issues 🎉
What changed in this PR
Corrects the English and Japanese documentation for wolfSSL_send_hrr_cookie, aligning examples and hash-selection guidance with the API. No runtime code changes are included.
Changes:
- Fixes the function name and uses
unsigned charfor the example secret buffer. - Clarifies default digest-size selection, including the
WOLFSSL_TLS13_SHA512requirement for SHA-512.
| File | Description |
|---|---|
doc/dox_comments/header_files/ssl.h |
Corrects the English example and clarifies SHA-512 availability. |
doc/dox_comments/header_files-ja/ssl.h |
Corrects the Japanese example and updates digest fallback guidance. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Function name in example code had extra underscore. 'secret' needs to be unsigned.
WOLFSSL_TLS13_SHA512 needs to be defined for SHA-512 to be used.