Closed
Conversation
When both new_certs_dir (from config) and -out option are specified, the paths were incorrectly concatenated without considering: 1. Absolute paths in -out should override new_certs_dir 2. Path separator was missing between directory and filename This fix: - Uses -out path directly if it is an absolute path - Adds path separator when appending relative paths Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests the fix for path concatenation bug: - Absolute -out path overrides new_certs_dir - Relative -out path is appended to new_certs_dir with separator Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both `new_certs_dir` (from config file) and `-out` option are
specified in the `ca` command, the output paths were incorrectly
concatenated.
Bug example:
Root Cause
In `wolfCLU_CertSignAppendOut()` (src/x509/clu_x509_sign.c), when appending
the `-out` path to `new_certs_dir`:
`new_certs_dir`
Fix
needed
Test Plan