Transform netcode to Go module/package#18
Open
kerak19 wants to merge 4 commits intowirepair:masterfrom
Open
Conversation
added 4 commits
February 8, 2019 10:11
Removed vendor directory along with Gopkg files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates netcode repository to use go modules instead of vendoring.
All tests are passing ✔️
Looks like there's problem with Travis havingGO111MODULE="auto"variable set, causing go to not use modulesPS. I'm not able to use
lintcommand from Makefile, because of this unknownfgtcommandPS2. Looks like Travis didn't build last version of my PR (which fix GO111MODULE misspell), if someone could replay the build manually it'll pass, as you can see here