Conversation
jbeich
left a comment
jbeich
left a comment
There was a problem hiding this comment.
Run time tested X11 not wayland
Beware, testing Wayland on FreeBSD is still blocked by winft/theseus-ship#9
como/base/CMakeLists.txt
Outdated
| FILE_SET HEADERS | ||
| FILES | ||
| os/clock/linux_skew_notifier_engine.h | ||
| os/clock/skew_notifier_engine.h |
There was a problem hiding this comment.
Looks unrelated. Did you accidentally squash #22?
| setenv("QT_QPA_PLATFORM", "wayland-org.kde.kwin.qpa", true); | ||
| setenv("KWIN_FORCE_OWN_QPA", "1", true); | ||
|
|
||
| #if HAVE_SCHED_RESET_ON_FORK |
There was a problem hiding this comment.
Looks unrelated. Did you accidentally squash downstream patch?
| locked++; | ||
| } | ||
|
|
||
| void unlock() |
There was a problem hiding this comment.
Looks unrelated. Did you accidentally squash #29 workaround?
|
Thanks for the PR. winft/theseus-ship#9 has been merged. Can you check on @jbeich's other comments? |
|
Can you check on @jbeich's other comments?
- 7ad1bc1 is fine by me and was [applied downstream](freebsd/freebsd-ports@3d2a4ef27e45)
- Maybe add "Fixes #30" to the PR description in order to [automatically close it on merge](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
|
jsm222
changed the title
|
Note this is Qt >=6.9 only as they renamed a private header to QtGui/private/qdesktopunixservices_p.h in qt/qtbase@7ab7d88 |
That's fine. The PR looks good to me. If there is nothing else can you @jsm222 add "Fixes #30" to the PR description so this PR closes the issue automatically on merge like was proposed? |
Added a naive null check for transient Added the nextStateChanged handler (not sure if correct) Added deco->create call to init the state Run time tested X11 not wayland Remove FreeBSD specific patches.
3 participants
Added a naive null check for transient
Added the nextStateChanged handler (not sure if correct)
Added deco->create call to init the state
Run time tested X11 not wayland