fix(builder,model): narrow string|callable type hints to string|Closure#56
Merged
Merged
Conversation
The where(), orWhere(), join() family, and Model::where() accepted `callable` in a union with `string`, even though the implementation only ever checks `instanceof \Closure`. Static analyzers (Intelephense and similar) treat a `callable` parameter as a potential function-name reference, so passing a plain column name like 'page_id' triggered a false "Call to unknown function" diagnostic in the IDE. Replacing `callable` with `\Closure` in these signatures matches the actual runtime behavior and removes the false positive, with no change in supported usage (only Closures were ever accepted as the callback form).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The where(), orWhere(), join() family, and Model::where() accepted
callablein a union withstring, even though the implementation only ever checksinstanceof \Closure. Static analyzers (Intelephense and similar) treat acallableparameter as a potential function-name reference, so passing a plain column name like 'page_id' triggered a false "Call to unknown function" diagnostic in the IDE.Replacing
callablewith\Closurein these signatures matches the actual runtime behavior and removes the false positive, with no change in supported usage (only Closures were ever accepted as the callback form).