Codify MCP tool name requirements and add title#152
Open
DavidMulder0 wants to merge 9 commits intowebmachinelearning:mainfrom
Open
Codify MCP tool name requirements and add title#152DavidMulder0 wants to merge 9 commits intowebmachinelearning:mainfrom
DavidMulder0 wants to merge 9 commits intowebmachinelearning:mainfrom
Conversation
domfarolino
reviewed
Mar 23, 2026
Co-authored-by: Dominic Farolino <[email protected]>
Author
|
First of all: Apologies for wasting your time and thank you for being kind about it. Sincerely hope I did better this time 😅. Anyway, I included the checks in the |
domfarolino
reviewed
Mar 24, 2026
Collaborator
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Don't sweat it, specs are hard! Thanks for the contribution.
Collaborator
|
I've pushed a couple small changes to make this more spec idiomatic. Can you take a look @DavidMulder0? |
domfarolino
approved these changes
Apr 8, 2026
Author
|
Thank you! Just fixed a typo and a missing verb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #145 and #133 .
(Related topic: some guidance regarding localization would be great.
namedoes not have to be localized presumably (it won't be shown to the user presumably).titlemay be localized. Willdescriptionbe shown to the end user? From personal experience I am treating that as a solid 'no' (all MCP descriptions I have written so far were 'prompt engineered'). Lastly I have seen the tool arguments get presented to the user relatively often, so should there be a way to localize the display of those?)