NFC-154 Deprecations, warning fixes and using formatter#69
Open
SanderKondratjevNortal wants to merge 10 commits intoweb-eid-mobilefrom
Open
NFC-154 Deprecations, warning fixes and using formatter#69SanderKondratjevNortal wants to merge 10 commits intoweb-eid-mobilefrom
SanderKondratjevNortal wants to merge 10 commits intoweb-eid-mobilefrom
Conversation
…edSigningCertificates fields testing.
…ow. Format Razor (.cshtml) files using C# formatter.
SanderKondratjevNortal
force-pushed
the
NFC-154
branch
from
858c103 to
b042675
Compare
mrts
requested changes
Apr 30, 2026
| configuration.SiteOrigin = origin; | ||
| if (logger?.IsEnabled(LogLevel.Debug) == true) | ||
| { | ||
| #pragma warning disable CA1848 |
Member
There was a problem hiding this comment.
Let's either disable or at least downgrade CA1848 repo-wide in .editorconfig:
dotnet_diagnostic.CA1848.severity = suggestion # or none
Then let's remove CA1848 pragmas.
Alternative is to use source-generated logging:
internal static partial class LogMessages
{
[LoggerMessage(EventId = 1001, Level = LogLevel.Debug, Message = "Origin set to {origin}")]
public static partial void OriginSet(this ILogger logger, String origin);
}Then call logger?.OriginSet(configuration.SiteOrigin).
But this might be too large effort.
| { | ||
| #pragma warning disable CA1848 | ||
| logger?.LogError(ex, "Error occurred while downloading user container file"); | ||
| #pragma warning disable CA1848 |
Member
There was a problem hiding this comment.
Typo:
Suggested change
| #pragma warning disable CA1848 | |
| #pragma warning restore CA1848 |
But let's get rid of CA1848, see previous comment.
| if (payload.signatureAlgorithm && typeof payload.signatureAlgorithm === "string") { | ||
| payload.signatureAlgorithm = { | ||
| id: payload.signatureAlgorithm, | ||
| name: payload.signatureAlgorithm |
Member
There was a problem hiding this comment.
Is this correct structure? SignatureDto is
SignatureDto
required SignatureAlgorithmDto SignatureAlgorithm
required string CryptoAlgorithm
required string HashFunction
required string PaddingScheme
mrts
reviewed
Apr 30, 2026
| dotnet build --configuration Release --no-restore src/WebEid.Security.sln | ||
| dotnet test src/WebEid.Security.sln --logger trx --collect:"XPlat Code Coverage" -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover --results-directory "TestResults" | ||
| .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}" | ||
| .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="$env:SONAR_TOKEN" |
Member
There was a problem hiding this comment.
Let's add dotnet format --verify-no-changes for format verification as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander KondratjevSander.Kondratjev@Nortal.com