Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

Add average function of numpy - #187

Open
courentin wants to merge 2 commits into
wearepal:masterfrom
courentin:add-numpy-average
Open

Add average function of numpy#187
courentin wants to merge 2 commits into
wearepal:masterfrom
courentin:add-numpy-average

Conversation

@courentin

Copy link
Copy Markdown

This PR add the average function of numpy.
I'm not 100% sure the signature is right though.

@tmke8

tmke8 commented Oct 29, 2020

Copy link
Copy Markdown
Member

I think you can just copy the signature of np.mean? Returning a Union is not so nice, because then the type checker always has to deal with all the types in the union.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants