You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PiCamera can be used as a low-cost and widely accessible entropy source for RNG (random number generation) by calibrating camera settings to maximize noise (see the LavaRnd website for more details). Previously, developers could only disable the secondary YUV420 de-noise algorithms.
Per #565'bayer_denoise': 1 << 10 can be added to the ISP_BLOCKS object so that it can be disabled via the PiCamera isp_blocks parameter.
To address the concerns from @6by9 about disrupting the image processing pipeline, disabling the Bayer de-noise ISP block would not stall it because image format is preserved, similar to the YUV420 de-noise algorithm.
To address the concerns from @6by9 about disrupting the image processing pipeline, disabling the Bayer de-noise ISP block would not stall it because image format is preserved, similar to the YUV420 de-noise algorithm.
Preserving the image format has nothing to do with my concerns.
The ISP works on tiles, and several of the processing stages require context pixels around those that it is actually processing. You're using configurations that have not been exercised before, therefore there is the potential for bugs to be lurking in those tile calculations.
If you're saying that it all works then that is great, but if there are issues then they won't be high on my priority list to fix.
Suffice to say that the patch looks reasonable to me, however this isn't my repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PiCamera can be used as a low-cost and widely accessible entropy source for RNG (random number generation) by calibrating camera settings to maximize noise (see the LavaRnd website for more details). Previously, developers could only disable the secondary YUV420 de-noise algorithms.
Per #565
'bayer_denoise': 1 << 10can be added to theISP_BLOCKSobject so that it can be disabled via the PiCameraisp_blocksparameter.To address the concerns from @6by9 about disrupting the image processing pipeline, disabling the Bayer de-noise ISP block would not stall it because image format is preserved, similar to the YUV420 de-noise algorithm.