chore(pr-agent): repoint the reusable pin to the current SHA (supersedes #84) - #86
chore(pr-agent): repoint the reusable pin to the current SHA (supersedes #84)#86wave-av-reviewbot[bot] wants to merge 3 commits into
Conversation
The pinned SHA predates ed47221e and 32af9cef, both already on wave-foundation origin/main. Without the per-attempt timeout budget from 32af9cef a slow review consumes the 15-minute job ceiling, which GitHub renders as `cancelled` and which continue-on-error structurally cannot trap — so the lane looks configured and silently does not run. 100 of the fleet's callers already use @main; this adopts that convention.
@main trips the fleet zizmor `unpinned-uses` ratchet (baseline 0): claude-workstation workflow-lint failed with "This PR ADDS a workflow-security finding". Pinning to 32af9cef — the last commit touching reusable-pr-agent.yml, and the one that ADDS the per-attempt timeout budget — keeps SHA-pinning intact while still carrying both fixes (ed47221e, 32af9cef) the previous pin lacked.
wave-foundation#1273 merged, which added a `lane version` step to the reusable that annotates the resolved lane SHA and warns when a caller pins behind 32af9cef. Bumping from 32af9cef to 4ac59c8c picks that up, so this caller lands current instead of one commit stale on merge. Still SHA-pinned — @main trips the zizmor unpinned-uses ratchet (baseline 0).
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR makes a one-line SHA-to-SHA update to the reusable pr-agent workflow, moving from 150ffae2 to the verified current 4ac59c8c commit while preserving immutable pinning and all existing workflow behavior. It also exercises the App-authored PR path needed to obtain an independent approval under the repository’s branch protection rules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The new commit can change the reusable workflow's CI behavior, including how the OPENAI_KEY secret is handled and what code runs with repository privileges. Reverting restores the old pin, but any secret exposure or other effects from a bad run would not be undone.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
| Filename | Overview |
|---|---|
| .github/workflows/pr-agent.yml | Updates only the reusable PR-agent workflow SHA; no concrete caller incompatibility or workflow regression was identified. |
Reviews (1): Last reviewed commit: "chore(pr-agent): bump the pin past the m..." | Re-trigger Greptile
What this changes
Repoints this repo's
pr-agentcaller fromreusable-pr-agent.yml@150ffae2to@4ac59c8c.One line, one file, SHA-to-SHA — the pin stays pinned.
Why now
4ac59c8cis the current head of that reusable workflow onwave-foundationmain(2026-08-25T16:39:06Z, verified against the commit list for that path, not inferred). The pin this
repo carries predates three merged fixes:
32af9ceff— port the four fixes the public mirror received83f83b2b8— the caller was a drifted inline copy4ac59c8c9— correct the reusable-caller documentationcli,mcp-serverandsdksstill carry the stale150ffae2today, so this is the first of a setrather than a one-off.
Why this PR is authored by the App, and the old one is not
This supersedes #84, which is identical in content and structurally unmergeable.
wave-avhas one human member. GitHub forbids approving a pull request you authored, and this reporequires one approving review with
enforce_admins: true. #84 was opened byyakimoto— the sameaccount that would have to approve it — so it sat green and unmergeable, and no amount of admin
rights changes that. Ten public repos are currently in that state.
The fix is authorship, not the review requirement: an agent opens the PR as the GitHub App, so
the founder is a genuinely distinct principal and the one-approval rule is satisfied rather than
deleted. That is now codified as
rules/agent-authored-public-prs-need-a-non-founder-author.md, merged toclaude-workstationmainin #3779 (01aa97a60).This PR is the first live exercise of that path. The App installation was verified to reach all 167
org repos, including this one, before it was used.
Note on the superseded body
#84's prose described repointing to
@main. That was an earlier approach, corrected before itlanded:
@mainis a mutable ref and trips thezizmorunpinned-usesratchet, whose baselineallows zero findings. The committed diff on both PRs is a SHA, not
@main— only #84's descriptionwas stale. This body says what the diff actually does.
Verification
.github/workflows/pr-agent.yml; no secrets, permissions or triggers touched.wave-foundationand to be the newest commit for that path.717df77cis unchanged from chore(pr-agent): repoint the reusable pin to the fixed SHA #84 — identical tree, so CI results carry over.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by Sourcery
Enhancements: