Skip to content

chore(pr-agent): repoint the reusable pin to the current SHA (supersedes #84) - #86

Open
wave-av-reviewbot[bot] wants to merge 3 commits into
mainfrom
app/chore-pr-agent-pin-fixed-sha
Open

chore(pr-agent): repoint the reusable pin to the current SHA (supersedes #84)#86
wave-av-reviewbot[bot] wants to merge 3 commits into
mainfrom
app/chore-pr-agent-pin-fixed-sha

Conversation

@wave-av-reviewbot

@wave-av-reviewbot wave-av-reviewbot Bot commented Aug 26, 2026

Copy link
Copy Markdown

What this changes

Repoints this repo's pr-agent caller from reusable-pr-agent.yml@150ffae2 to @4ac59c8c.
One line, one file, SHA-to-SHA — the pin stays pinned.

Why now

4ac59c8c is the current head of that reusable workflow on wave-foundation main
(2026-08-25T16:39:06Z, verified against the commit list for that path, not inferred). The pin this
repo carries predates three merged fixes:

  • 32af9ceff — port the four fixes the public mirror received
  • 83f83b2b8 — the caller was a drifted inline copy
  • 4ac59c8c9 — correct the reusable-caller documentation

cli, mcp-server and sdks still carry the stale 150ffae2 today, so this is the first of a set
rather than a one-off.

Why this PR is authored by the App, and the old one is not

This supersedes #84, which is identical in content and structurally unmergeable.

wave-av has one human member. GitHub forbids approving a pull request you authored, and this repo
requires one approving review with enforce_admins: true. #84 was opened by yakimoto — the same
account that would have to approve it — so it sat green and unmergeable, and no amount of admin
rights changes that. Ten public repos are currently in that state.

The fix is authorship, not the review requirement: an agent opens the PR as the GitHub App, so
the founder is a genuinely distinct principal and the one-approval rule is satisfied rather than
deleted
. That is now codified as
rules/agent-authored-public-prs-need-a-non-founder-author.md, merged to claude-workstation
main in #3779 (01aa97a60).

This PR is the first live exercise of that path. The App installation was verified to reach all 167
org repos, including this one, before it was used.

Note on the superseded body

#84's prose described repointing to @main. That was an earlier approach, corrected before it
landed: @main is a mutable ref and trips the zizmor unpinned-uses ratchet, whose baseline
allows zero findings. The committed diff on both PRs is a SHA, not @main — only #84's description
was stale. This body says what the diff actually does.

Verification

  • Diff is one line in .github/workflows/pr-agent.yml; no secrets, permissions or triggers touched.
  • Target SHA confirmed to exist on wave-foundation and to be the newest commit for that path.
  • Head SHA 717df77c is unchanged from chore(pr-agent): repoint the reusable pin to the fixed SHA #84 — identical tree, so CI results carry over.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by Sourcery

Enhancements:

  • Update the reusable PR-agent workflow reference to the latest immutable commit SHA.

Review in cubic

The pinned SHA predates ed47221e and 32af9cef, both already on wave-foundation
origin/main. Without the per-attempt timeout budget from 32af9cef a slow review
consumes the 15-minute job ceiling, which GitHub renders as `cancelled` and which
continue-on-error structurally cannot trap — so the lane looks configured and
silently does not run.

100 of the fleet's callers already use @main; this adopts that convention.
@main trips the fleet zizmor `unpinned-uses` ratchet (baseline 0): claude-workstation
workflow-lint failed with "This PR ADDS a workflow-security finding". Pinning to
32af9cef — the last commit touching reusable-pr-agent.yml, and the one that ADDS the
per-attempt timeout budget — keeps SHA-pinning intact while still carrying both fixes
(ed47221e, 32af9cef) the previous pin lacked.
wave-foundation#1273 merged, which added a `lane version` step to the reusable
that annotates the resolved lane SHA and warns when a caller pins behind
32af9cef. Bumping from 32af9cef to 4ac59c8c picks that up, so this caller lands
current instead of one commit stale on merge.

Still SHA-pinned — @main trips the zizmor unpinned-uses ratchet (baseline 0).
@codeant-ai

codeant-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@sourcery-ai

sourcery-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR makes a one-line SHA-to-SHA update to the reusable pr-agent workflow, moving from 150ffae2 to the verified current 4ac59c8c commit while preserving immutable pinning and all existing workflow behavior. It also exercises the App-authored PR path needed to obtain an independent approval under the repository’s branch protection rules.

File-Level Changes

Change Details Files
Updates the reusable PR-agent workflow reference to the verified current commit while retaining immutable SHA pinning.
  • Replaces the stale workflow SHA with the newer target SHA.
  • Leaves the workflow path, secrets wiring, triggers, permissions, and other configuration unchanged.
.github/workflows/pr-agent.yml
Uses App-authored PRs to satisfy the repository’s required independent approval constraint for this maintenance change.
  • Supersedes the structurally unmergeable predecessor without changing the implementation diff.
  • Relies on the established non-founder authoring path rather than weakening branch protections.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. The new commit can change the reusable workflow's CI behavior, including how the OPENAI_KEY secret is handled and what code runs with repository privileges. Reverting restores the old pin, but any secret exposure or other effects from a bad run would not be undone.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown

Greptile Summary

Repoints the PR-agent reusable workflow from one immutable commit SHA to a newer immutable commit SHA.

  • Keeps the reusable workflow fully pinned.
  • Leaves triggers, permissions, concurrency, and secret forwarding unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it only updates an immutable reusable-workflow pin and no concrete failure was identified.

The caller’s triggers, permissions, concurrency settings, and OPENAI_KEY mapping remain unchanged, and the diff introduces no established behavioral or security defect.

Important Files Changed

Filename Overview
.github/workflows/pr-agent.yml Updates only the reusable PR-agent workflow SHA; no concrete caller incompatibility or workflow regression was identified.

Reviews (1): Last reviewed commit: "chore(pr-agent): bump the pin past the m..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant