Slave hack#28
Open
GuyBlumenthal wants to merge 8 commits into
Open
Conversation
| } else if (pkt.addr <= 14) { | ||
| // We are dealing with one of the temp sensors. We will store them in the first two cell temperatures | ||
| global_bms_data.battery.cells[pkt.addr - 13].temp = UINT_TO_FLOAT(*((uint32_t*)pkt.payload)); | ||
| } else {} // Something went wrong, idk maybe do something? |
Contributor
There was a problem hiding this comment.
not sure what the limitations of the perfboard slave device are but can we send an error message via uart? something like a printf statement would be sufficient
Nushaab-Syed
approved these changes
May 27, 2022
Nushaab-Syed
left a comment
Nushaab-Syed
left a comment
Contributor
There was a problem hiding this comment.
just left a minor comment in slave_thread.cpp regarding sending an error message via uart when encountering a problem with parsing a msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.