This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Modify clangService.ts for multiple sources support#452
Closed
nokotan wants to merge 2 commits intowasdk:masterfrom
Closed
Modify clangService.ts for multiple sources support#452nokotan wants to merge 2 commits intowasdk:masterfrom
nokotan wants to merge 2 commits intowasdk:masterfrom
Conversation
Author
|
I've decided to rename branch, closing this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #365 #298
Here's the contributing guide at https://github.com/wasdk/WebAssemblyStudio/wiki/Contributing
Summary of Changes
I have made changes to src/compilerServices/clangService.ts for the multiple files support.
(almost same changes in Now We can Use Header File . #365; not updated for long time, I made this PR.)
Test Plan
Current test cases in tests/compilerServices/clangService.spec.ts are designed for single c source file and expected to rename this to "file.c", some test cases fail.
So I check my implementation manually... (should modify test cases, but I'm not sure that the modification is appropriate in this PR.)
Failing test cases:
Screenshots/Videos (OPTIONAL)