fix: drop stale tmux commands after SSH exit#12220
Draft
oz-for-oss[bot] wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: oz-for-x[bot] <284697482+oz-for-x[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12215
Summary
PtyControllerwhen tmux control mode is no longer active.new-window, from being written into the local shell after an SSH session exits.Validation
./script/formatCARGO_BUILD_JOBS=1 cargo test -p warp drops_tmux_command_when_control_mode_is_inactive --libCARGO_BUILD_JOBS=1 cargo test -p warp formats_tmux_command_when_control_mode_is_active --libCARGO_BUILD_JOBS=1 cargo clippy -p warp --lib -- -D warningsNotes
cargo nextest run -p warp -E 'test(pty_controller)'attempt was killed by SIGKILL during compilation in the sandbox, so the new tests were rerun individually with one cargo build job.cargo clippy -p warp --all-targets --all-features --tests -- -D warningswas blocked by a missing generatedpreview_config.jsonfor the preview binary test target; library clippy passed.