Skip to content

fix: drop stale tmux commands after SSH exit#12220

Draft
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-12215
Draft

fix: drop stale tmux commands after SSH exit#12220
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-12215

Conversation

@oz-for-oss
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot commented Jun 4, 2026

Closes #12215

Summary

  • Drop tmux control-mode commands in PtyController when tmux control mode is no longer active.
  • Prevent stale background tmux commands, including new-window, from being written into the local shell after an SSH session exits.
  • Add focused unit tests for inactive-control-mode dropping and active-control-mode formatting.

Validation

  • ./script/format
  • CARGO_BUILD_JOBS=1 cargo test -p warp drops_tmux_command_when_control_mode_is_inactive --lib
  • CARGO_BUILD_JOBS=1 cargo test -p warp formats_tmux_command_when_control_mode_is_active --lib
  • CARGO_BUILD_JOBS=1 cargo clippy -p warp --lib -- -D warnings

Notes

  • A broader cargo nextest run -p warp -E 'test(pty_controller)' attempt was killed by SIGKILL during compilation in the sandbox, so the new tests were rerun individually with one cargo build job.
  • cargo clippy -p warp --all-targets --all-features --tests -- -D warnings was blocked by a missing generated preview_config.json for the preview binary test target; library clippy passed.

Co-Authored-By: oz-for-x[bot] <284697482+oz-for-x[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH session exit auto-runs tmux new-window command

1 participant