Skip to content

feat: bring over connected labels to warp app#12214

Open
dmichelin wants to merge 1 commit into
masterfrom
add_connected_label
Open

feat: bring over connected labels to warp app#12214
dmichelin wants to merge 1 commit into
masterfrom
add_connected_label

Conversation

@dmichelin

Copy link
Copy Markdown
Contributor

Description

This PR brings over some of the worker-host visibility improvements that were done to Oz recently, exposing a "Connected" label for hosts that can be dispatched.

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

image

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: {{Connected self-hosted workers now have a "Connected" label in the oz worker dropdown}}

@cla-bot cla-bot Bot added the cla-signed label Jun 4, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@dmichelin

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@dmichelin dmichelin requested a review from bnavetta June 4, 2026 20:03

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds right-side Default, Connected, and Disconnected labels to the orchestration host pickers and switches one picker to action-based selection so badge text is no longer part of the primary item label. Visual evidence is present in the PR description, and no spec context was available.

Concerns

  • The inline orchestration host picker no longer keeps an existing initial worker host in the dropdown unless it is currently connected, the default, warp, or already saved as the recent host. That makes some existing remote configs/requests open the custom editor instead of showing the selected disconnected host row.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@@ -928,11 +928,6 @@ pub fn populate_host_picker<V: View>(
};
let mut connected_hosts = ConnectedSelfHostedWorkersModel::as_ref(ctx)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] Removing the initial host from the menu source means an existing remote config/request whose worker_host is not currently connected and is not the persisted recent host is treated as unknown by set_selected, which opens the custom editor instead of showing the disconnected row. Keep initial in the item list as a disconnected option so existing selections remain visible and editable.

@dmichelin dmichelin requested a review from zachbai June 4, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant