feat: bring over connected labels to warp app#12214
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds right-side Default, Connected, and Disconnected labels to the orchestration host pickers and switches one picker to action-based selection so badge text is no longer part of the primary item label. Visual evidence is present in the PR description, and no spec context was available.
Concerns
- The inline orchestration host picker no longer keeps an existing initial worker host in the dropdown unless it is currently connected, the default, warp, or already saved as the recent host. That makes some existing remote configs/requests open the custom editor instead of showing the selected disconnected host row.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| @@ -928,11 +928,6 @@ pub fn populate_host_picker<V: View>( | |||
| }; | |||
| let mut connected_hosts = ConnectedSelfHostedWorkersModel::as_ref(ctx) | |||
There was a problem hiding this comment.
worker_host is not currently connected and is not the persisted recent host is treated as unknown by set_selected, which opens the custom editor instead of showing the disconnected row. Keep initial in the item list as a disconnected option so existing selections remain visible and editable.
Description
This PR brings over some of the worker-host visibility improvements that were done to Oz recently, exposing a "Connected" label for hosts that can be dispatched.
Testing
./script/runScreenshots / Videos
Agent Mode
CHANGELOG-IMPROVEMENT: {{Connected self-hosted workers now have a "Connected" label in the oz worker dropdown}}