Skip to content

Support custom scheme URL autolinks#12213

Open
xiaogwu wants to merge 1 commit into
warpdotdev:masterfrom
xiaogwu:fix/custom-scheme-url-autolinks
Open

Support custom scheme URL autolinks#12213
xiaogwu wants to merge 1 commit into
warpdotdev:masterfrom
xiaogwu:fix/custom-scheme-url-autolinks

Conversation

@xiaogwu
Copy link
Copy Markdown

@xiaogwu xiaogwu commented Jun 4, 2026

Summary

  • detect and autolink non-HTTP custom scheme URLs such as vscode://...
  • preserve existing urlocator handling for HTTP/HTTPS URLs
  • respect existing URL boundaries: styled links/placeholders/newlines split detection segments
  • trim common trailing punctuation and unmatched closing delimiters

Fixes #5659

Testing

  • cargo fmt --check
  • cargo test -p warp_editor test_highlight -- --nocapture

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Jun 4, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @xiaogwu on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 4, 2026

@xiaogwu

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #5659, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 4, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaogwu

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #5659, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hope mouse click could support custom "URL Schemes"

1 participant