Integrate core notification data model into lws10-core#185
Open
laurensdeb wants to merge 2 commits into
Open
Conversation
Move the general notification concepts (discovery, envelope data model, activity types, subscription model) from lws10-notifications into lws10-core/Notifications.html, following the same pattern used for authentication (core data model in lws10-core, channel-specific suites in separate specs). lws10-notifications is restructured to contain only the Webhook notification suite, analogous to lws10-authn-openid for authentication. Changes: - Add lws10-core/Notifications.html with core notification data model - Add notification terms to lws10-core terminology section - Add Notifications section to lws10-core/index.html - Add notification security/privacy considerations to core - Rewrite lws10-notifications as Webhook notification suite referencing core definitions via LWS10-CORE Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
elf-pavlik
approved these changes
Jun 30, 2026
elf-pavlik
left a comment
elf-pavlik
left a comment
Member
There was a problem hiding this comment.
I'm assuming that content didn't chage and it only was reorganized.
Aligns with the authn naming convention (lws10-authn-openid, lws10-authn-saml, etc.) now that the core notification data model lives in lws10-core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the notification specification to follow the same pattern used for authentication:
lws10-core/Notifications.html(analogous toAuthentication.html)lws10-notifications/as the Webhook notification suite (analogous tolws10-authn-openid/)What moved to lws10-core
What stays in lws10-notifications (Webhook suite)
WebhookSubscription)Design rationale
This mirrors how authentication is structured:
lws10-core/Authentication.htmldefines the credential data model, validation requirements, and type identifierslws10-authn-openid/,lws10-authn-saml/, etc. define channel-specific serialization and validationSimilarly:
lws10-core/Notifications.htmldefines the notification data model, subscription model, and discoverylws10-notifications/(Webhooks) defines channel-specific delivery, authentication, and managementThis enables future notification suites (e.g., SSE, WebSocket) to be added as separate specs that reference the core data model.
Preview | Diff