#301: sh:values and sh:defaultValue#310
Conversation
…xpression Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
HolgerKnublauch
requested review from
YoucTagh,
afs,
ashleysommer,
bergos,
siwerner and
tpluscode
tpluscode
left a comment
tpluscode
left a comment
There was a problem hiding this comment.
Do we actually want to include SPARQL expressions in Core?
Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com>
HolgerKnublauch
changed the title
|
Now that the main branch contains the sh:SelectExpression, I have updated this branch against the main branch, which will make it much easier to review. |
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Not requesting changes with the GitHub button, but if any of my requests aren't acceptable as they are, please don't merge until we come to agreement on the revisions to these areas.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
| If the <code>sh:path</code> is not a <a>well-formed</a> property path, it must be a <a>node expression</a> | ||
| and the constraints will be validated against the <a>output nodes</a> of this node expression. | ||
| Note that support for node expressions is not required by SHACL Core, | ||
| Note that support for <code>sh:values</code> and <code>sh:defaultValue</code> is not required by SHACL Core, |
There was a problem hiding this comment.
Can we just say:
| Note that support for <code>sh:values</code> and <code>sh:defaultValue</code> is not required by SHACL Core, | |
| Note that `sh:values` and `sh:defaultValue` are not used by SHACL Core, |
There was a problem hiding this comment.
I prefer the pre-edit wording. Presence in SHACL-Core notes the terms should be recognized as in the SHACL vocabulary, but knowing their functionality is explicitly "not required" is a clearer statement to me.
There was a problem hiding this comment.
Recognizing SHACL vocabulary would imply some basic "support"?
I wanted to capture that they can be syntactically correct and not processed in the "SHACL Core profile" (to come...).
There was a problem hiding this comment.
I suppose I'm fine with it. Though, the next line would need its grammar aligned.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
6 participants
This implements my comment at #301 (comment) which is basically what we have in SHACL-AF and what has been implemented in TopBraid for many years.
Note the PR includes the changes for SHACL-SPARQL introducing sh:select for technical reasons, because the separate PR for that is currently blocked for process reasons. #297 (comment)