wip: vapor mode

[zhiyuanzmj]

Description

This PR provide two vapor components: VaporRouterView and VaporRouterLink.
I'm not sure whether we should provide a vue-router/vapor for users to make migration easier.

import { RouterView } from 'vue-router/vapor'

export default () => <RouterView />

The access globalProperties warning should be remove.

• fix(runtime-vapor): remove access globalProperties warning core#13609

Playground

https://repl.zmjs.dev/vuejs/vue-router

TODO

• Tests
• Playground

[netlify]

✅ Deploy Preview for vue-router canceled.

Name	Link
🔨 Latest commit	ef302bd
🔍 Latest deploy log	https://app.netlify.com/projects/vue-router/deploys/6943bc25f6d50a0008f2d353

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vue-router@2509

commit: ef302bd

[posva]

Note for myself for refactoring and simplification: Playground

• Second iteration in TS

[Reinhard-Berger]

Is this already compatible with “3.6.0-alpha.1”?
Or is there still work required? I’d be happy to help if I can.

[zhiyuanzmj]

Is this already compatible with “3.6.0-alpha.1”? Or is there still work required? I’d be happy to help if I can.

You can try it in [email protected]

[absidue]

The automatic global registration of the virtual DOM RouterView and RouterLink components in the install hook should probably be removed so that they can be tree-shaken when an app is only using the Vapor ones.

[posva]

FYI this is planned after #2415 which will also allow to register a custom RouterView and RouterLink

[nevmerzhitsky]

Is this a last blocker of the epic of embedding Vapor into the core?

[posva]

No

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 25.45455% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.76%. Comparing base (3e3efef) to head (ef302bd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/router/src/VaporRouterView.ts	15.74%	91 Missing ⚠️
packages/router/src/VaporRouterLink.ts	42.85%	32 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
- Coverage   91.26%   88.76%   -2.51%     
==========================================
  Files          46       48       +2     
  Lines        4180     4344     +164     
  Branches     1113     1113              
==========================================
+ Hits         3815     3856      +41     
- Misses        358      481     +123     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.